Rename ParentOrElse sampler to ParentBased and enhance it according to the spec #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2020 21:16
- Renaming of type and sampler function - Enhancing ParentBased with sampler options - Set default samplers for each applicable parent-based case - Adjust ShouldSample(...) func accordingly
- add tests for ParentBased sampler options and description - renaming in trace_test.go
matej-g
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
========================================
+ Coverage 77.7% 77.9% +0.2%
========================================
Files 135 135
Lines 7153 7191 +38
========================================
+ Hits 5559 5603 +44
+ Misses 1350 1344 -6
Partials 244 244
|
Aneurysm9
reviewed
Sep 9, 2020
MrAlias
reviewed
Sep 9, 2020
- More clearer naming of structs; add comments where missing - Adhere to the configuration style guide
|
Thanks for the feedback, I reworked the configuration so that it adheres to the styling guide, hopefully now all is A-OK. |
MrAlias
approved these changes
Sep 10, 2020
Aneurysm9
approved these changes
Sep 10, 2020
6 tasks
KasonBraley
added a commit
to KasonBraley/opentelemetry-go-contrib
that referenced
this pull request
Feb 16, 2023
Update the examples to use the current API for configuring production sampling. These names were changed a couple of years ago. open-telemetry/opentelemetry-go#1115 open-telemetry/opentelemetry-go#1153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant specification change from open-telemetry/opentelemetry-specification#610
More specifically, the changes include:
ParentOrElsesampler toParentBasedfallbacksampler renamed torootremoteParentSampled,remoteParentNotSampled,localParentSampled,localParentNotSampled); if not set, appropriate defaults are used in accordance with the specResolves #1084